[PATCH] D72369: DWARFDebugLine.cpp: Format NULL as "(null)" to avoid UB
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 07:53:05 PST 2020
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
In D72369#1812104 <https://reviews.llvm.org/D72369#1812104>, @jhenderson wrote:
> I'd still really like to see a test that tests the other code path that tries to print DW_LNS_* (see the inline comment). The obvious thing to me to do would be to update the unit test "ParserPrintsStandardOpcodesWhenRequested", but it would require changes to the DwarfGenerator to create a custom prologue. If you don't want to do this, that's okay, as the code path is already untested.
Yes, that is rather out-of-the-way for what this patch is doing. My understanding is that you would be okay with letting this patch land?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72369/new/
https://reviews.llvm.org/D72369
More information about the llvm-commits
mailing list