[PATCH] D72280: [Matrix] Add IR MatrixBuilder.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/IR/MatrixBuilder.h:47
+                                       unsigned ResultNumElementsFlattened,
+                                       const Twine &Name = "") {
+
----------------
LuoYuanke wrote:
> Is ResultNumElementsFlattened needed? I notice there is no comments for this parameter in the function head.
> ResultNumElementsFlattened  = Rows * Columns?
ResultNumElementsFlattened is indexed unnecessary here and elsewhere in this patch. I've removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72280/new/

https://reviews.llvm.org/D72280