[PATCH] D72280: [Matrix] Add IR MatrixBuilder.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/include/llvm/IR/MatrixBuilder.h:47
+                                       unsigned ResultNumElementsFlattened,
+                                       const Twine &Name = "") {
+
----------------
Is ResultNumElementsFlattened needed? I notice there is no comments for this parameter in the function head.
ResultNumElementsFlattened  = Rows * Columns?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72280/new/

https://reviews.llvm.org/D72280