[PATCH] D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 07:40:55 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5122
+      .Cases("__divdi3", "__fixdfdi", "__fixunsdfdi", "__floatdidf",
+             "__floatdisf", "__floatundidf", "__floatundisf", "__moddi3",
+             "__udivdi3", "__umoddi3", true)
----------------
hubert.reinterpretcast wrote:
> There is no demonstration that we should expect to encounter `__floatdisf`. Should we retain it in this list? Similarly for other cases not present in the test.
Same situation with `__floatdidf` on the new diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70718/new/

https://reviews.llvm.org/D70718





More information about the llvm-commits mailing list