[PATCH] D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove

Wed Jan 8 07:40:46 PST 2020

jasonliu added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll:55
+
+; 32-REL: LLVM ERROR: Unexpanded relocation output not implemented.
+
----------------
Testing for this error does not make sense. I'm not sure if we plan to support unexpanded relocation anytime soon. 
If you want to test relocation, you should add in --expand-relocs as one of your llvm-readobj option.
But currently the relocation patch is under review/revision, you would not get any relocation info, and it does not make sense for you to test something that's "invalid".
I'm not sure if you could do any better than a TODO here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70718/new/

https://reviews.llvm.org/D70718