[PATCH] D72310: [mlir][VectorOps] Implement strided_slice conversion

[Andy Davis via Phabricator via llvm-commits]

andydavis1 accepted this revision.
andydavis1 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:737
+
+static Value extractOne(PatternRewriter &rewriter, Location loc, Value vector,
+                        int64_t offset) {
----------------
These will be merged with other CL, yes?


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:794
+        // be called multiple times by the PatternRewrite infrastructure (to
+        // avoid infinite recursion, but in this case we know what we are
+        // doing).
----------------
Same comment as other CL, comment on how recursion terminates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72310/new/

https://reviews.llvm.org/D72310