[PATCH] D72298: Add zero_extendi and sign_extendi to intrinsic namespace

Pruthvi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 11:51:34 PST 2020


pruthviIntel added inline comments.


================
Comment at: mlir/test/EDSC/builder-api-test.cpp:515
+    // edsc::intrinsics::sign_extendi(ValueHandle(ValueA(i, j), i8Type)
+    edsc::intrinsics::sign_extendi(*A(i, j), i8Type);
+  });
----------------
nicolasvasilache wrote:
> can both tests be folded into a single test?
> Or better yet into a previously exisiting test to avoid duplicating boilerplate?
@nicolasvasilache sure, will fold both of them under a single test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72298/new/

https://reviews.llvm.org/D72298





More information about the llvm-commits mailing list