[PATCH] D72298: Add zero_extendi and sign_extendi to intrinsic namespace
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 6 19:01:35 PST 2020
nicolasvasilache requested changes to this revision.
nicolasvasilache added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/test/EDSC/builder-api-test.cpp:515
+ // edsc::intrinsics::sign_extendi(ValueHandle(ValueA(i, j), i8Type)
+ edsc::intrinsics::sign_extendi(*A(i, j), i8Type);
+ });
----------------
can both tests be folded into a single test?
Or better yet into a previously exisiting test to avoid duplicating boilerplate?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72298/new/
https://reviews.llvm.org/D72298
More information about the llvm-commits
mailing list