[PATCH] D72348: AMDGPU: Apply i16 add->sub pattern with zext to i32

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 11:03:58 PST 2020


rampitec added a comment.

In D72348#1808350 <https://reviews.llvm.org/D72348#1808350>, @arsenm wrote:

> In D72348#1808333 <https://reviews.llvm.org/D72348#1808333>, @rampitec wrote:
>
> > Will it correctly work with and without sram-ecc? I.e. do we have any assumptions about high 16 content of an i16 value anywhere?
>
>
> That only matters for memory accesses as far as I know. This isn't really a new pattern, and the existing predicates don't check


It is more than memory as far as I know, even arithmetic instructions will either zero or preserve the high bits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72348/new/

https://reviews.llvm.org/D72348





More information about the llvm-commits mailing list