[PATCH] D72234: [llvm-readelf] Print EI_ABIVERSION as decimal instead of hexadecimal

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 01:49:51 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. I have no idea why this was hex in the first place.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3065
+  printFields(OS,
+              "ABI Version:", std::to_string(e->e_ident[ELF::EI_ABIVERSION]));
   Str = printEnum(e->e_type, makeArrayRef(ElfObjectFileType));
----------------
BTW, do you know the rationale for using llvm::to_string versus std::to_string? Both are widely used in the code base...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72234/new/

https://reviews.llvm.org/D72234





More information about the llvm-commits mailing list