[PATCH] D72112: [mlir][Linalg] NFC - Post-commit cleanups
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 3 10:15:12 PST 2020
nicolasvasilache marked an inline comment as done.
nicolasvasilache added inline comments.
================
Comment at: mlir/include/mlir/Support/Functional.h:50
+template <typename Fn, typename IterType>
+auto map_filter(Fn fun, IterType begin, IterType end)
+ -> SmallVector<typename std::result_of<Fn(decltype(*begin))>::type, 8> {
----------------
rriddle wrote:
> This seems hardcoded for a very specific type of iterator element, i.e. one where the result is nullable.
I can rename to `map_if_non_null`.
I was reluctant on forcing a second lambda and turn into a `map_if` but I could do that too and impl `map_if_non_null` in terms of that.
Thoughts?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72112/new/
https://reviews.llvm.org/D72112
More information about the llvm-commits
mailing list