[PATCH] D72112: [mlir][Linalg] NFC - Post-commit cleanups

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 09:58:14 PST 2020


rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/include/mlir/Support/Functional.h:50
+template <typename Fn, typename IterType>
+auto map_filter(Fn fun, IterType begin, IterType end)
+    -> SmallVector<typename std::result_of<Fn(decltype(*begin))>::type, 8> {
----------------
This seems hardcoded for a very specific type of iterator element, i.e. one where the result is nullable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72112/new/

https://reviews.llvm.org/D72112





More information about the llvm-commits mailing list