[PATCH] D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 3 07:44:22 PST 2020
jhenderson created this revision.
jhenderson added reviewers: ikudrin, JDevlieghere, dblaikie, probinson, MaskRay.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
This was missed in previous changes to the debug line parser.
Depends on D72158 <https://reviews.llvm.org/D72158>.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72159
Files:
llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
Index: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
@@ -190,7 +190,6 @@
// the end of the prologue.
static llvm::Expected<ContentDescriptors>
parseV5EntryFormat(const DWARFDataExtractor &DebugLineData, uint64_t *OffsetPtr,
- uint64_t EndPrologueOffset,
DWARFDebugLine::ContentTypeTracker *ContentTypes) {
ContentDescriptors Descriptors;
int FormatCount = DebugLineData.getU8(OffsetPtr);
@@ -216,15 +215,14 @@
static Error
parseV5DirFileTables(const DWARFDataExtractor &DebugLineData,
- uint64_t *OffsetPtr, uint64_t EndPrologueOffset,
- const dwarf::FormParams &FormParams,
+ uint64_t *OffsetPtr, const dwarf::FormParams &FormParams,
const DWARFContext &Ctx, const DWARFUnit *U,
DWARFDebugLine::ContentTypeTracker &ContentTypes,
std::vector<DWARFFormValue> &IncludeDirectories,
std::vector<DWARFDebugLine::FileNameEntry> &FileNames) {
// Get the directory entry description.
llvm::Expected<ContentDescriptors> DirDescriptors =
- parseV5EntryFormat(DebugLineData, OffsetPtr, EndPrologueOffset, nullptr);
+ parseV5EntryFormat(DebugLineData, OffsetPtr, nullptr);
if (!DirDescriptors)
return DirDescriptors.takeError();
@@ -251,8 +249,8 @@
}
// Get the file entry description.
- llvm::Expected<ContentDescriptors> FileDescriptors = parseV5EntryFormat(
- DebugLineData, OffsetPtr, EndPrologueOffset, &ContentTypes);
+ llvm::Expected<ContentDescriptors> FileDescriptors =
+ parseV5EntryFormat(DebugLineData, OffsetPtr, &ContentTypes);
if (!FileDescriptors)
return FileDescriptors.takeError();
@@ -354,9 +352,9 @@
}
if (getVersion() >= 5) {
- if (Error e = parseV5DirFileTables(
- DebugLineData, OffsetPtr, EndPrologueOffset, FormParams, Ctx, U,
- ContentTypes, IncludeDirectories, FileNames)) {
+ if (Error E =
+ parseV5DirFileTables(DebugLineData, OffsetPtr, FormParams, Ctx, U,
+ ContentTypes, IncludeDirectories, FileNames)) {
RecoverableErrorCallback(joinErrors(
createStringError(
errc::invalid_argument,
@@ -364,7 +362,7 @@
" found an invalid directory or file table description at"
" 0x%8.8" PRIx64,
PrologueOffset, *OffsetPtr),
- std::move(e)));
+ std::move(E)));
// Skip to the end of the prologue, since the chances are that the parser
// did not read the whole table. This prevents the length check below from
// executing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72159.236064.patch
Type: text/x-patch
Size: 2843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200103/f1c0a6ba/attachment.bin>
More information about the llvm-commits
mailing list