[PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ikudrin, JDevlieghere, dblaikie, probinson, MaskRay.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
jhenderson added a child revision: D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming.

Many of the debug line prologue errors are not inherently fatal. In most cases, we can make reasonable assumptions and carry on. This patch does exactly that. In the case of length problems, the approach of "assume bigger is correct" is taken to avoid double-parsing the same code.

Depends on D72157 <https://reviews.llvm.org/D72157>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72158

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72158.236063.patch
Type: text/x-patch
Size: 19464 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200103/99c0c5a3/attachment.bin>