[PATCH] D72062: [mlir][spirv] Fix shader ABI attribute prefix and add verification

[Kazuaki Ishizaki via Phabricator via llvm-commits]

kiszk added inline comments.


================
Comment at: mlir/test/Dialect/SPIRV/target-and-abi.mlir:54
+
+// expected-error @+1 {{'spv.interface_var_abi' attribute must be a dictionary attribute containing three integer attribute: 'descriptor_set', 'binding', and 'storage_class'}}
+func @interface_var(
----------------
nit: `attribute`-> `attributes`?
Same comments to other places


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72062/new/

https://reviews.llvm.org/D72062