[PATCH] D72062: [mlir][spirv] Fix shader ABI attribute prefix and add verification
Kazuaki Ishizaki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 2 10:46:53 PST 2020
kiszk added inline comments.
================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp:679
+ << "' attribute must be a dictionary attribute containing three "
+ "integer attribute: 'descriptor_set', 'binding', and "
+ "'storage_class'";
----------------
nit: `attribute` -> `attributes`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72062/new/
https://reviews.llvm.org/D72062
More information about the llvm-commits
mailing list