[PATCH] D72069: [NFC] Add explicit instantiation to releaseNode
qshanz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 2 02:34:49 PST 2020
steven.zhang added a comment.
In D72069#1800924 <https://reviews.llvm.org/D72069#1800924>, @fhahn wrote:
> In D72069#1800869 <https://reviews.llvm.org/D72069#1800869>, @steven.zhang wrote:
>
> > If you want to pass it with parameter, why not change the signature of releaseNode directly instead of adding a wrapper. We need to make decision about template arguments vs function parameter :)
>
>
> +1. I think just passing InPQueue would keep things simpler and it should get inlined anyways ;)
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72069/new/
https://reviews.llvm.org/D72069
More information about the llvm-commits
mailing list