[PATCH] D72069: [NFC] Add explicit instantiation to releaseNode

[Lorenzo Casalino via Phabricator via llvm-commits]

DoktorC added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:762
+  void releaseNode(SUnit *SU, unsigned ReadyCycle, unsigned Idx = 0) {
+    releaseNodeImpl(SU, ReadyCycle, Idx, InPQueue);
+  }
----------------
lkail wrote:
> I think adding an `Impl` method might break origin author's intention. With a template parameter, compiler can remove some dead branches at compile time.
You got the point @lkail. For a (verbose) explanation of my intent, refer to my last comment
https://reviews.llvm.org/D65506#1800921


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72069/new/

https://reviews.llvm.org/D72069