[PATCH] D72033: [AArch64] Enable post-RA sched for more cores

Tue Dec 31 04:22:35 PST 2019

fhahn added a comment.

This makes sense, assuming you are happy with the performance numbers you are seeing for Arm cores.

But I am not sure what the tests check exactly. Wouldn’t it be sufficient to check if the post ra scheduler is run per default for the additional cores?

For the other tests, it would be helpful to simplify the MIR (I think you should be able to get rid of the IR) and add a comment saying what this checks. And maybe precommit them and just have the diff of what changed here.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:542
                                    FeatureFuseAES,
+                                   FeatureFuseLiterals,
                                    FeatureNEON,
----------------
This is unrelated to the postra scheduling, right? It would be slightly better to split it off and have it as separate change, with tests just for the feature

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72033/new/

https://reviews.llvm.org/D72033