[PATCH] D68850: [Utils] Deal with occasionally deleted functions

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:268
+  # blacklist are prefixes we cannot use to print the function because it doesn't exist in run lines that use these prefixes as well.
+  blacklist = set()
   printed_prefixes = []
----------------
lebedev.ri wrote:
> I'm having a hard time figuring out whether this `blacklist` is per-function or global.
> I.e. what happens if `sometimes_deleted_function.ll` has a second function,
> that *does* exist for all check prefixes. Will it also only be checked in `FIRST` check prefix?
It's a *per function* blacklist. I updated the test to show that `ALL` is used for a function that is always present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68850/new/

https://reviews.llvm.org/D68850