[PATCH] D68850: [Utils] Deal with occasionally deleted functions
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 30 23:57:51 PST 2019
lebedev.ri added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:268
+ # blacklist are prefixes we cannot use to print the function because it doesn't exist in run lines that use these prefixes as well.
+ blacklist = set()
printed_prefixes = []
----------------
I'm having a hard time figuring out whether this `blacklist` is per-function or global.
I.e. what happens if `sometimes_deleted_function.ll` has a second function,
that *does* exist for all check prefixes. Will it also only be checked in `FIRST` check prefix?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68850/new/
https://reviews.llvm.org/D68850
More information about the llvm-commits
mailing list