[PATCH] D71917: Optimization of inserting vxi1 sub vector into vXi1 vector

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 29 17:33:50 PST 2019


xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:5902
+    APInt Mask0(NumElems, 0);
+    Mask0.setBits(IdxVal, IdxVal + SubVecNumElems);
+    Mask0.flipAllBits();
----------------
RKSimon wrote:
> APInt Mask0 = APInt::getBitsSet(NumElems, IdxVal, IdxVal + SubVecNumElems) ?
Yes! getBitsSet is better, I'll change it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71917/new/

https://reviews.llvm.org/D71917





More information about the llvm-commits mailing list