[PATCH] D71916: High-Level Code-Review Documentation Update

[Hal Finkel via Phabricator via llvm-commits]

hfinkel marked an inline comment as done.
hfinkel added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:48
+
+Please note: There is no bar for post-commit feedback that is higher than for
+pre-commit feedback. Don't delay unnecessarily in providing feedback, but if
----------------
MaskRay wrote:
> The bar for post-commit feedback is not higher than pre-commit feedback ?
Do you disagree? This is an important question. I've never felt that there is a higher bar, but I've certainly heard people say that they feel otherwise in practice. I don't think that's optimal - if someone has feedback, we should hear it, and they shouldn't feel barred by the fact that the commit has happened already.

Clearly there a practical timing issue: if I comment on a patch after the committer has stopped working on the project, I might not receive any reply, and I'll really just need to submit a patch myself. If there are additional distinctions that we wish to capture, I'm certainly happy to try to do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916