[PATCH] D71916: High-Level Code-Review Documentation Update

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:48
+
+Please note: There is no bar for post-commit feedback that is higher than for
+pre-commit feedback. Don't delay unnecessarily in providing feedback, but if
----------------
The bar for post-commit feedback is not higher than pre-commit feedback ?


================
Comment at: llvm/docs/CodeReview.rst:67
+intrinsics), adding language extensions in Clang, and so on, require an RFC on
+`*-dev` first. For changes that promise significant impact on users and/or
+downstream code bases, reviewers can request an RFC (Request for Comment)
----------------
  ``*-dev``


================
Comment at: llvm/docs/CodeReview.rst:207
+  asking for valuable time from other professional developers.
+* Ask for help on IRC. Developers on IRC will be able to either help you
+  directly, or tell you who might be a good reviewer.
----------------
mehdi_amini wrote:
> "Ask for help on IRC or Discord."?
>From https://lists.llvm.org/pipermail/llvm-dev/2019-November/136880.html , people are concerned about Discord's user policy. Not mentioning it here (before we reach a consensus) should be fine.


================
Comment at: llvm/docs/CodeReview.rst:210
+* Split your patch into multiple smaller patches that build on each other. The
+  smaller your patch, the higher the probability that somebody will take a quick
+  look at it.
----------------
smaller your patch //is//


================
Comment at: llvm/docs/CodeReview.rst:217
+on a patch, but patches should be approved only consistent with the policy above.
+
----------------
Delete the trailing empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916