[PATCH] D71841: [FPEnv] Default NoFPExcept SDNodeFlag to false

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 15:58:42 PST 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:3462
+      // Remember whether NodeToMatch could raise an FP exception.
+      bool MayRaiseFPException = mayRaiseFPException(NodeToMatch) &&
+                                 !NodeToMatch->getFlags().hasNoFPExcept();
----------------
Why is only NodeToMatch important? Couldn't we be pattern matching multiple strict nodes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71841/new/

https://reviews.llvm.org/D71841





More information about the llvm-commits mailing list