[PATCH] D71777: [RISCV][NFC] Deduplicate Atomic Intrinsic Definitions

[James Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D71777#1795201 <https://reviews.llvm.org/D71777#1795201>, @luismarques wrote:

> In D71777#1795194 <https://reviews.llvm.org/D71777#1795194>, @jrtc27 wrote:
>
> > I would personally rather this remain unindented, much like we do with `namespace llvm` etc.
>
>
> I too was a bit surprised by the formatting (especially the indented section separator) but @lenary told me he just ran `clang-format` on the file. And I looked around and saw that some other tablegen files in LLVM also used this style of formatting, so taken together I deemed the patch style reasonable during the review. But it's true that not indenting is the most common style and has its advantages, so I would also favour keeping it unindented.


I guess TableGen is close enough to C/C++ in syntax... but given our TableGen style in the project is generally less indented (and TableGen is often hand-formatted for clarity due to all the DAG nodes), I'd still be inclined to use the original unindented formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71777/new/

https://reviews.llvm.org/D71777