[PATCH] D71777: [RISCV][NFC] Deduplicate Atomic Intrinsic Definitions
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 23 12:32:40 PST 2019
luismarques added a comment.
In D71777#1795194 <https://reviews.llvm.org/D71777#1795194>, @jrtc27 wrote:
> I would personally rather this remain unindented, much like we do with `namespace llvm` etc.
I too was a bit surprised by the formatting (especially the indented section separator) but @lenary told me he just ran `clang-format` on the file. And I looked around and saw that some other tablegen files in LLVM also used this style of formatting, so taken together I deemed the patch style reasonable during the review. But it's true that not indenting is the most common style and has its advantages, so I would also favour keeping it unindented.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71777/new/
https://reviews.llvm.org/D71777
More information about the llvm-commits
mailing list