[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I inlined remaining minor comments from my side. @uenoku you should finish the review and accept once your happy.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2095
+  bool isKnownToCauseUB(Instruction *I) const override {
+    return (KnownUBInsts.count(I) != 0);
+  }
----------------
Just count, no need to check it against 0.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2123
   ChangeStatus manifest(Attributor &A) override {
-    if (!UBMemAccessInsts.size())
+    if (!KnownUBInsts.size())
       return ChangeStatus::UNCHANGED;
----------------
`!XXX.size()` -> `XXX.empty()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799