[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

Tue Dec 24 13:58:38 PST 2019

jdoerfert added a comment.

In D71799#1795512 <https://reviews.llvm.org/D71799#1795512>, @baziotis wrote:

> In D71799#1795492 <https://reviews.llvm.org/D71799#1795492>, @uenoku wrote:
>
> > But now it seems it's more useful to reach an optimistic fixpoint when the value is constant or undef, so I can agree to change it(D71852 <https://reviews.llvm.org/D71852>).
>
>
> Great, thank you for the quick action! After reading the above again, maybe then we want to not break the conceptual idea of `AAValueSimplify`. Actually let me comment on the other revision.

We can change things if it makes sense. What I would prefer to do wrt. AAValueSimplify is to get D68934 <https://reviews.llvm.org/D68934> in. I'll put a new revision online as soon as I can, make the diff easier to read and test it some more. Though the version that is online should be very close to what it'll be.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799