[PATCH] D71803: [llvm-nm] Display STT_GNU_IFUNC as 'i'
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 23 11:51:14 PST 2019
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1137
+ else {
+ if (elf_symbol_iterator(I)->getELFType() == ELF::STT_GNU_IFUNC)
+ return 'i';
----------------
grimar wrote:
> Why not to place the new logic inside `getSymbolNMTypeChar` ?
> It would be consistent with `STB_GNU_UNIQUE` I think.
Place the new logic inside getSymbolNMTypeChar will be more complex.
For both global and local symbols, the key is the lower case `i`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71803/new/
https://reviews.llvm.org/D71803
More information about the llvm-commits
mailing list