[PATCH] D71803: [llvm-nm] Display STT_GNU_IFUNC as 'i'

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/ifunc.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-nm --no-sort %t | FileCheck %s
----------------
Add a file comment?


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1137
+  else {
+    if (elf_symbol_iterator(I)->getELFType() == ELF::STT_GNU_IFUNC)
+      return 'i';
----------------
Why not to place the new logic inside `getSymbolNMTypeChar` ?
It would be consistent with `STB_GNU_UNIQUE` I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71803/new/

https://reviews.llvm.org/D71803