[PATCH] D71817: Fix LLVM tool --version build mode printing for MSVC

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

https://github.com/llvm/llvm-project/blob/74c5fac3bba77d796132c313b77c808b2165b75d/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h

Worth to fix too?



================
Comment at: llvm/lib/Support/CommandLine.cpp:2439
 
+#if defined(__GNUC__)
+// GCC and GCC-compatible compilers define __OPTIMIZE__ when optimizations are
----------------
rnk wrote:
> xbolva00 wrote:
> > Move to compiler.h?
> This is the only existing use of `__OPTIMIZE__` in LLVM or clang, so I would prefer to keep it local until there is another use. I hope there will never be one, it's generally not a good idea to ifdef on whether optimizations are enabled.
Maybe you overlooked my comment but there is one more:

https://github.com/llvm/llvm-project/blob/master/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h#L99


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71817/new/

https://reviews.llvm.org/D71817