[PATCH] D71817: Fix LLVM tool --version build mode printing for MSVC

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:2439
 
+#if defined(__GNUC__)
+// GCC and GCC-compatible compilers define __OPTIMIZE__ when optimizations are
----------------
xbolva00 wrote:
> Move to compiler.h?
This is the only existing use of `__OPTIMIZE__` in LLVM or clang, so I would prefer to keep it local until there is another use. I hope there will never be one, it's generally not a good idea to ifdef on whether optimizations are enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71817/new/

https://reviews.llvm.org/D71817