[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 03:56:12 PST 2019


lenary added a comment.

Selfishly, I would like to see the addition of `rvintrin.h` separated from the bit-manipulation-specific headers. I'm looking at landing some additions to clang/LLVM that include builtins, and don't want to cause merge issues with this PR.

I haven't yet had time to fully absorb the bit manipulation spec to ensure that these functions, when emulated, match it.



================
Comment at: clang/lib/Headers/rv32bintrin-builtins.h:48
+// Genric aliases
+// e.g. _rv_* is an alias of _rv64_*
+
----------------
Nit: I don't think this is the case here, based on the calls in the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67661/new/

https://reviews.llvm.org/D67661





More information about the llvm-commits mailing list