[PATCH] D69954: [OpenMP][Opt] Delete read-only parallel regions

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Aside from the inline comment about functions that don't return, this looks good to me. Simple code, heavily tested. Thanks



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:127
+        return false;
+
+      LLVM_DEBUG(dbgs() << Tag << "Delete read-only parallel region in "
----------------
I'm not totally confident that onlyReadsMemory is sufficient here (concerned about I/O, functions that do not return).

LICM hoists based on this so it's safe for I/O. Likewise malloc/free are fine.

Please could you point me to the reason this is safe for functions that don't return?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69954/new/

https://reviews.llvm.org/D69954