[PATCH] D71763: [yaml2obj] - Add testing for OSABI field.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 07:08:34 PST 2019


grimar added a comment.

In D71763#1792782 <https://reviews.llvm.org/D71763#1792782>, @jhenderson wrote:

> This is fine, but I wonder what you think about testing using `od`, to avoid things being circular here? Presumably you will use yaml2obj to test llvm-readobj prints the right value for the field, which means that theoretically, both could be broken in the same way and we wouldn't notice.


Well. But we know the correct enum values from start, don't we? For example we check `OS/ABI: CloudABI (0x11)`, we know that enum value of `ELFOSABI_CLOUDABI`  is `0x11`,
and that llvm-readelf dumps the same. So it can't be broken I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71763/new/

https://reviews.llvm.org/D71763





More information about the llvm-commits mailing list