[PATCH] D71763: [yaml2obj] - Add testing for OSABI field.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 20 06:58:28 PST 2019


jhenderson added a comment.

This is fine, but I wonder what you think about testing using `od`, to avoid things being circular here? Presumably you will use yaml2obj to test llvm-readobj prints the right value for the field, which means that theoretically, both could be broken in the same way and we wouldn't notice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71763/new/

https://reviews.llvm.org/D71763





More information about the llvm-commits mailing list