[PATCH] D71645: [NFC][InlineCost] Simplify internal inlining cost interface

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

There is comment like this:

  /// The candidate callsite being analyzed. Please do not use this to do
  /// analysis in the caller function; we want the inline cost query to be
  /// easily cacheable. Instead, use the cover function paramHasAttr.
  CallBase &CandidateCall;

Can you find out the history of this field?

On the other hand, if a different callsite is passed to analyzeCall other than CandidateCall, it will produce wrong results.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71645/new/

https://reviews.llvm.org/D71645