[PATCH] D70986: [DDG] Data Dependence Graph - Ordinals

Thu Dec 19 08:02:05 PST 2019

bmahjour added a comment.

In D70986#1790336 <https://reviews.llvm.org/D70986#1790336>, @Meinersbur wrote:

> In D70986#1790305 <https://reviews.llvm.org/D70986#1790305>, @bmahjour wrote:
>
> > The order is at the mercy of SCCIterator. For example if you look at the first pi-block node in basic-a.ll, you'll notice that prior to this change the `%inc = add i64 %i.02, 1` was placed ahead of `%i.02 = phi `.
>
>
> I see. Could you add that as a comment to either `computeInstructionOrdinals` and/or the invocation of `llvm::sort`.

Done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70986/new/

https://reviews.llvm.org/D70986