[PATCH] D70986: [DDG] Data Dependence Graph - Ordinals

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 13:41:31 PST 2019


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

In D70986#1790305 <https://reviews.llvm.org/D70986#1790305>, @bmahjour wrote:

> The order is at the mercy of SCCIterator. For example if you look at the first pi-block node in basic-a.ll, you'll notice that prior to this change the `%inc = add i64 %i.02, 1` was placed ahead of `%i.02 = phi `.


I see. Could you add that as a comment to either `computeInstructionOrdinals` and/or the invocation of `llvm::sort`.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70986/new/

https://reviews.llvm.org/D70986





More information about the llvm-commits mailing list