[PATCH] D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:7
+# RUN: llvm-readobj --symbols %t64 | FileCheck %s --check-prefix=SYMBOLS-LLVM
+# RUN: llvm-readelf --symbols %t64 | FileCheck %s --strict-whitespace --check-prefix=SYMBOLS-GNU64
+# RUN: yaml2obj %s --docnum=2 -o %t32
----------------
You probably want --match-full-lines here and elsewhere.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:69
+# NO-T-ERR: Unknown command line argument '-t'
+## -s is a llvm-readobj option to dump sections.
+# RUN: llvm-readobj -s --elf-output-style=GNU %t64 | FileCheck %s --implicit-check-not="Symbol table"
----------------
I //think// this should be "is an llvm-readobj".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71697/new/

https://reviews.llvm.org/D71697