[PATCH] D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 03:14:46 PST 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: seiya, rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This cleans up and merges `gnu-symbols.test` to `symbols.test`.
Initially `gnu-symbols.test` tested the following things:

1. How symbols are printed in GNU style. It does not make sense to have a separate file for such tests.
2. It tried to test proc-specific symbol indexes. The test was incomplete and also we already have `symbol-shndx.test` for that, so this part was removed.
3. It tested `--dyn-symbols` and `--symbols` correlation. All following cases were moved to `symbols.test`: a) That `--dyn-symbols` does not trigger showing regular symbols.. b) That `--symbols` triggers `--dyn-symbols` implicitly. c) That `--dyn-symbols` and `--symbols` works fine together.


https://reviews.llvm.org/D71697

Files:
  llvm/test/tools/llvm-readobj/ELF/Inputs/relocs.obj.elf-x86_64
  llvm/test/tools/llvm-readobj/ELF/Inputs/symbols-proc-specific.elf-hexagon
  llvm/test/tools/llvm-readobj/ELF/gnu-symbols.test
  llvm/test/tools/llvm-readobj/ELF/symbols.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71697.234691.patch
Type: text/x-patch
Size: 9968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191219/7cbf63e9/attachment.bin>


More information about the llvm-commits mailing list