[PATCH] D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built.

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

Ah I see. Well, I think the build target existing even if it's not added to "all" is fine. Which is what BUILD_TOOLS controls:

  macro(add_llvm_tool name)
    if( NOT LLVM_BUILD_TOOLS )
      set(EXCLUDE_FROM_ALL ON)
    endif()

What could trip someone up is:

  $ cmake -G Ninja ../llvm-project/llvm/ -DLLVM_BUILD_TOOLS=OFF
  $ ninja llvm-locstats
  [1/1] Copying llvm-locstats into /work/open_source/llvm-project-build/./bin
  $ bin/llvm-locstats <stuff>

Since building llvm-locstats doesn't implicitly build llvm-dwarfdump. Is that one of the scenarios you were thinking of?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71695/new/

https://reviews.llvm.org/D71695