[PATCH] D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built.
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 03:14:46 PST 2019
djtodoro added a comment.
In D71695#1790979 <https://reviews.llvm.org/D71695#1790979>, @DavidSpickett wrote:
> In D71695#1790971 <https://reviews.llvm.org/D71695#1790971>, @djtodoro wrote:
>
> > Sorry for the confusion. May be the `llvm/CMakeLists.txt` is better place to address this?
> >
> > llvm/CMakeLists.txt:
> >
> > if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
> > add_subdirectory(utils/llvm-locstats)
> > endif()
>
>
> Changing it to:
>
> if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS AND LLVM_BUILD_TOOLS)
> add_subdirectory(utils/llvm-locstats)
>
>
> Doesn't help the issue, but maybe I'm missing your point here?
Yes that was my point. Should we add the `AND LLVM_BUILD_TOOLS` part in both of the `llvm/CMakeLists.txt` and `llvm/utils/llvm-locstats/CMakeLists.txt`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71695/new/
https://reviews.llvm.org/D71695
More information about the llvm-commits
mailing list