[PATCH] D71346: [PowerPC] support loop ds form prep for lwa

[ChenZheng via Phabricator via llvm-commits]

shchenz marked 2 inline comments as done.
shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp:850
     return !isa<IntrinsicInst>(I) &&
            ((PtrValue->getType()->getPointerElementType()->isIntegerTy(64)) ||
             (PtrValue->getType()->getPointerElementType()->isFloatTy()) ||
----------------
nemanjai wrote:
> This expression is quite unwieldy. The repeated calls to `PtrValue->getType()->getPointerElementType()` just look a bit messy. It would make sense to define a local variable to simplify this condition.
will do this in commit patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71346/new/

https://reviews.llvm.org/D71346