[PATCH] D71595: [llvm-readobj][test] - Improve dyn-symbols.test.

Wed Dec 18 05:40:16 PST 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:68
+  - Type: PT_LOAD
+    VAddr: 0x0000
+    Sections:
----------------
jhenderson wrote:
> Doesn't this need to be 0x100 too? Possibly not strictly, but otherwise the VAddr viewed via the program header won't match that in the section header. The tag would need updating too.
> but otherwise the VAddr viewed via the program header won't match that in the section header. 
Right, but isn't that good for this test? We are trying to test that "dynamic symbol table found via the DT_SYMTAB dynamic tag".
Ideally we do not want to have a section header at all (but we can't).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71595/new/

https://reviews.llvm.org/D71595