[PATCH] D71595: [llvm-readobj][test] - Improve dyn-symbols.test.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 05:27:28 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:68
+  - Type: PT_LOAD
+    VAddr: 0x0000
+    Sections:
----------------
Doesn't this need to be 0x100 too? Possibly not strictly, but otherwise the VAddr viewed via the program header won't match that in the section header. The tag would need updating too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71595/new/

https://reviews.llvm.org/D71595





More information about the llvm-commits mailing list