[PATCH] D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2.

[Alexey Lapshin via Phabricator via llvm-commits]

avl marked 3 inline comments as done.
avl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:20
+
+enum class DwarfOptimizerClient { Dsymutil, LLD, General };
+
----------------
JDevlieghere wrote:
> This isn't used (yet)?
right. This would be used with last patch extracted from D70709. I decided that it is OK to put it this time. But If it would be better to move it into last patch then I would remove it for now.  


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:76
+
+  /// returns all valid functions address ranges(i.e. those addresses
+  /// which points to sections with code)
----------------
JDevlieghere wrote:
> Comments should be sentences. 
Ok.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:80
+
+  /// erase all data
+  virtual void clear() = 0;
----------------
JDevlieghere wrote:
> Same here, needs capitalization and full stop.
OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71271/new/

https://reviews.llvm.org/D71271