[PATCH] D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2.
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 17 11:26:14 PST 2019
JDevlieghere added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:20
+
+enum class DwarfOptimizerClient { Dsymutil, LLD, General };
+
----------------
This isn't used (yet)?
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:76
+
+ /// returns all valid functions address ranges(i.e. those addresses
+ /// which points to sections with code)
----------------
Comments should be sentences.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFOptimizer.h:80
+
+ /// erase all data
+ virtual void clear() = 0;
----------------
Same here, needs capitalization and full stop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71271/new/
https://reviews.llvm.org/D71271
More information about the llvm-commits
mailing list