[PATCH] D71591: [llvm-readob] - Refactor printing of sections flags. NFCI.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 03:57:12 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one comment.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1527
+    auto I = llvm::find_if(FlagsList, [=](const EnumEntry<unsigned> &E) {
+      // Flags with empty names are known to be unused for the GNU style output.
+      return E.Value == Flag && !E.AltName.empty();
----------------
are known to be unused for the GNU style -> are not printed in GNU style


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71591/new/

https://reviews.llvm.org/D71591





More information about the llvm-commits mailing list